fix: 11 - add validation of Zenodo API URL and deposition_id - #780
Merged
Conversation
daniel-rdt
marked this pull request as ready for review
July 3, 2026 10:36
tgilon
requested changes
Jul 3, 2026
tgilon
left a comment
Member
There was a problem hiding this comment.
Thank you @daniel-rdt, I think this can be simplified a bit
# Conflicts: # doc/release_notes.rst
# Conflicts: # doc/release_notes.md
Co-authored-by: Thomas Gilon <thomas.gilon@openenergytransition.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR proposes to add missing validation of
ZENODO_API_URLandeposition_idto thecreate_zenodo_deposition_cliutils script to safeguard against URL manipulation.Tasks
open-tyndpspecificWorkflow
Open issues
Notes
The following test script was used to verify the implementation:
verify_zenodo_api_validation.py
Generative AI was used to assist with code implementation of this PR. All content has been reviewed, verified, and is the responsibility of the author.
Checklist
pixi.toml(usingpixi add <dependency-name>).config/config.default.yaml.doc/configtables/*.csv.config/test/*.yaml.pixi run -e open-tyndp tyndp-cyears-test).doc/*.rstfiles.doc/release_notes.rstis added.doc/index.rst.